Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix #7546 - styling for flat interface #7547

Merged
merged 1 commit into from
Mar 13, 2017
Merged

fix #7546 - styling for flat interface #7547

merged 1 commit into from
Mar 13, 2017

Conversation

jamesmudgett
Copy link
Contributor

@jamesmudgett jamesmudgett commented Mar 8, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #7546

Test Plan:

@bsclifton
Copy link
Member

@jamesmudgett can you attach a screenshot? 😄

@jamesmudgett
Copy link
Contributor Author

screen shot 2017-03-10 at 11 29 11 am

@jamesmudgett
Copy link
Contributor Author

screen shot 2017-03-10 at 11 30 56 am

@bsclifton bsclifton self-requested a review March 10, 2017 23:45
@bsclifton bsclifton removed their assignment Mar 10, 2017
@bsclifton
Copy link
Member

@bradleyrichter should this be configurable? Or should these changes replace what we have?

I really like it- great job @jamesmudgett 😄 I'd vote to have this replace what we have currently

@bsclifton bsclifton added the design A design change, especially one which needs input from the design team. label Mar 10, 2017
@bsclifton bsclifton requested a review from luixxiul March 10, 2017 23:49
@bradleyrichter
Copy link
Contributor

@bsclifton It's almost ready. Just needs an adjustment for the BM bar and maybe some color adjustment. @jamesmudgett knocked it out while we were sitting in the all-hands. : )

@bradleyrichter
Copy link
Contributor

and yes, it can replace what we have.

@luixxiul
Copy link
Contributor

If you show the bookmark toolbar, the unnecessary border is displayed under the bookmark bar:

screenshot 2017-03-11 22 39 17

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the cropped image above.

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Mar 11, 2017 via email

@jamesmudgett
Copy link
Contributor Author

I think removing the borders is a nice solution, cleaner and simpler.

@jamesmudgett
Copy link
Contributor Author

screen shot 2017-03-11 at 12 40 59 pm

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Mar 11, 2017 via email

@jamesmudgett
Copy link
Contributor Author

@bradleyrichter can you post screenshot, or push to branch?

@bsclifton
Copy link
Member

This is looking good! Here's a screenshot on macOS:
screen shot 2017-03-12 at 2 39 26 am

Notice now that after the borders have been removed, there is a color difference (dark block under bookmarks toolbar). That needs to have its color adjusted

@bsclifton
Copy link
Member

bsclifton commented Mar 12, 2017

Windows looks good too! 👍 Love these changes!! 😄

Here's another thing I caught: there is no border under tabs which are not active. This may be intended, but it can look a little weird. In the following screenshot, notice the missing border under the Twitter tab
screen shot 2017-03-12 at 3 01 52 am

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback left- really good job 😄 Will keep an eye on this PR and re-review after changes

@jamesmudgett
Copy link
Contributor Author

img_3235

Slight adjustment from original design tabs area intentionally slightly darker than bookmarks and address bar area to create a bit of contrast. See original design above instead of two tone for tabs area carried over darker gray into inactive tabs as well to boost contrast to active tab and simplify space. Good call on inactive tab bottom border.

@jamesmudgett
Copy link
Contributor Author

screen shot 2017-03-13 at 5 33 07 pm

@cezaraugusto
Copy link
Contributor

I did a rebase and after convo with @bradleyrichter on Slack this looks ready with only a minor touch-up but I think that can be done as a follow-up.

I have some work to do on top of it so I'll merge.

btw @jamesmudgett this looks awesome +++++++++

@cezaraugusto cezaraugusto merged commit 0919732 into master Mar 13, 2017
@bsclifton bsclifton deleted the issue-7546 branch March 13, 2017 23:49
@cndouglas
Copy link

Just noticed the new look on master. Great stuff!

@luixxiul luixxiul added this to the 0.13.6 milestone Mar 14, 2017
@@ -39,13 +39,14 @@ html,
}

.top {
background: linear-gradient(to bottom, #fbfbfb, #ededed, );
background: linear-gradient(to bottom, #eaeaea, #f2f2f2, );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a stray , at the end of the gradient?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants