-
Notifications
You must be signed in to change notification settings - Fork 975
fix #7546 - styling for flat interface #7547
Conversation
@jamesmudgett can you attach a screenshot? 😄 |
@bradleyrichter should this be configurable? Or should these changes replace what we have? I really like it- great job @jamesmudgett 😄 I'd vote to have this replace what we have currently |
@bsclifton It's almost ready. Just needs an adjustment for the BM bar and maybe some color adjustment. @jamesmudgett knocked it out while we were sitting in the all-hands. : ) |
and yes, it can replace what we have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the cropped image above.
Yes. I tried removing both top and bottom border on the bm bar and it looks better.
… On Mar 11, 2017, at 5:42 AM, Suguru Hirahara ***@***.***> wrote:
@luixxiul requested changes on this pull request.
Please see the cropped image above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I think removing the borders is a nice solution, cleaner and simpler. |
I also lightened the URL box border about 30% and tried a light grey to white gradient from top to bottom. (Clear bg on bm bar) This lightens up the chrome but adds contrast to the tab bar and still allows the white URL BG to show. See what you think...
… On Mar 11, 2017, at 12:41 PM, James Matthew Mudgett ***@***.***> wrote:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@bradleyrichter can you post screenshot, or push to branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback left- really good job 😄 Will keep an eye on this PR and re-review after changes
Slight adjustment from original design tabs area intentionally slightly darker than bookmarks and address bar area to create a bit of contrast. See original design above instead of two tone for tabs area carried over darker gray into inactive tabs as well to boost contrast to active tab and simplify space. Good call on inactive tab bottom border. |
e11e15e
to
9c97840
Compare
I did a rebase and after convo with @bradleyrichter on Slack this looks ready with only a minor touch-up but I think that can be done as a follow-up. I have some work to do on top of it so I'll merge. btw @jamesmudgett this looks awesome +++++++++ |
Just noticed the new look on master. Great stuff! |
@@ -39,13 +39,14 @@ html, | |||
} | |||
|
|||
.top { | |||
background: linear-gradient(to bottom, #fbfbfb, #ededed, ); | |||
background: linear-gradient(to bottom, #eaeaea, #f2f2f2, ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that a stray ,
at the end of the gradient?
git rebase -i
to squash commits (if needed).Fixes #7546
Test Plan: